Add a new config_seeder that accepts consul parameters + Fix documentation#39
Closed
kalistace wants to merge 3 commits intobreser:masterfrom
Closed
Add a new config_seeder that accepts consul parameters + Fix documentation#39kalistace wants to merge 3 commits intobreser:masterfrom
kalistace wants to merge 3 commits intobreser:masterfrom
Conversation
kalistace
changed the title
Contributor
Author
|
Looks like #40 is addressing the same issue. Let me know if you want me to revert the last 2 commits and only merge the documentation fix :) |
Collaborator
|
Wow, 2 patches solving the same problem within hours of each other? What are the odds! If you could separate the documentation fix from the config_seeder change, that would be great. It'll make it easier to evaluate the two approaches, and I think it's cool to have PRs that do a single thing. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR try to fix the issue mentioned here #28.
I decided to create a whole new seeder to prevent breaking backward compatibility with the previous version of git2consul.
I realised I made some mistakes in the documentation for this PR #38.
Sorry about that, this PR fixes that as well.